ci: add required-review #3964
Closed
ci: add required-review #3964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-gray
force-pushed
the
required-review
branch
2 times, most recently
from
e1a4d9d
to
4ed0f7e
Compare
evan-gray
force-pushed
the
required-review
branch
2 times, most recently
from
d1575dc
to
572ef52
Compare
evan-gray
force-pushed
the
required-review
branch
from
572ef52
to
4cc36a7
Compare
|
After further review, there are several shortcomings with a GHA actions approach, including
Using rulesets to increase restrictions for users with write access is likely a better approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this PR is to allow for required reviewers which do not have write access to the repo. In order to achieve this, it leverages action-required-review.
In the short term this could co-exist with the full set of CODEOWNERS and eventually be the sole enforcer for much of the codebase, with the likely exception of the
.githubfolder itself, or at least this action, which should probably remain protected by CODEOWNERS. The fallback could also remain with some users with write access if explicit approval from someone with write on every PR was desired.Reviewers - I have attempted to replicate the existing CODEOWNERS rules in
.github/required-review.yml, but please confirm they match.The name field is optional, but I was leaning towards providing it for clarity.
Note that this config will match multiple entries, unlike CODEOWNERS which matches the last one. Therefore the ordering has been switched and some entries set to
consume: true. See the Requirements Format for more details.